[webkit-reviews] review denied: [Bug 38016] Update padding on Windows? : [Attachment 57428] Patch v1 - a typo fix

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 38016: Update padding on Windows?
https://bugs.webkit.org/show_bug.cgi?id=38016

Attachment 57428: Patch v1 - a typo fix
https://bugs.webkit.org/attachment.cgi?id=57428&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Adele, hyatt, mitz I'd appreciate if one of you could approve this. The code
looks good to me. I'm hesitant to r+ since I'm the one who suggested the change
in the first place. 

(In reply to comment #5)
> (From update of attachment 57428 [details])
> This patch will change the layout test results on windows. I'm planning to
land an expectation fix soon after this patch is landed. It seems my windows
machine doesn't generate the same output as the buildbot.

Unfortunately, the bots will stop running the tests after 20 tests have failed
(we really should increase that number to 100 or something). So, we'll need to
find another way to get new test results. I also have never succeeded in
getting all the layout tests to pass on Windows. It's a bit gross, but we could
add the tests to the Windows skipped list, then take 15 off at a time and grab
those results off the bot. If you do that during off-hours for PST, I think
it's probably OK.

r- for the tests since this can't be submitted as is.