[webkit-reviews] review denied: [Bug 40461] [Chromium] Dragging outside the frame immediately causes page to scroll : [Attachment 58871] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 11:25:40 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 40461: [Chromium] Dragging outside the frame immediately causes page to
scroll
https://bugs.webkit.org/show_bug.cgi?id=40461

Attachment 58871: patch v1
https://bugs.webkit.org/attachment.cgi?id=58871&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebViewImpl.cpp:167
 +  class WebDragScrollTimer {
this should get its own .h,.cpp files.	it should not be prefixed
with Web since it is not part of the WebKit API.  DragScrollTimer
should be fine.


More information about the webkit-reviews mailing list