[webkit-reviews] review denied: [Bug 40381] [Qt] for debugging purposes I'm contributing back my FPS counter in the AnimationQtBase : [Attachment 58898] Pull from origin and reapply patch, fix style issues.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40381: [Qt] for debugging purposes I'm contributing back my FPS counter in
the AnimationQtBase
https://bugs.webkit.org/show_bug.cgi?id=40381

Attachment 58898: Pull from origin and reapply patch, fix style issues.
https://bugs.webkit.org/attachment.cgi?id=58898&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
In the future please make style changes not belonging to the patch itself in a
separate patch

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:45
 +  #define QT_DEBUG_FPS 1
You really want to summit it with 1 here?


WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1131
 +	    if ( newState == Running && oldState == Stopped ) {
wrong style

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1135
 +	    } else if ( newState == Stopped && oldState == Running ) {
here as well

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1192
 +	int   m_frames;
here as well