[webkit-reviews] review denied: [Bug 39902] [Qt] QtWebKit does not support viewport meta tag : [Attachment 58699] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 39902: [Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902

Attachment 58699: patch
https://bugs.webkit.org/attachment.cgi?id=58699&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebKit/qt/Api/qwebpage.cpp:1681
 +	: d(new QtViewportHintsPrivate(this))
Almost :) Since we're not using it currently, we can save some cycles and
initialize d to 0 here.

WebKit/qt/Api/qwebpage.cpp:1694
 +  QWebPage::ViewportHints::ViewportHints(const QWebPage::ViewportHints&
other)
This copy constructor must also copy the member variables.

WebKit/qt/Api/qwebpage.cpp:1712
 +  QWebPage::ViewportHints& QWebPage::ViewportHints::operator=(const
QWebPage::ViewportHints& other)
Same here, the member variables need to be copied.