[webkit-reviews] review canceled: [Bug 39302] [Chromium] WebDevToolsAgentClient::sendMessageToFrontendOnIOThread needs to be implemented as virtual function : [Attachment 58859] fixed style error

[bugzilla-daemon at webkit.org]

Mikhail Naganov <mnaganov at chromium.org> has canceled Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 39302: [Chromium] WebDevToolsAgentClient::sendMessageToFrontendOnIOThread
needs to be implemented as virtual function
https://bugs.webkit.org/show_bug.cgi?id=39302

Attachment 58859: fixed style error
https://bugs.webkit.org/attachment.cgi?id=58859&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
Chromium change is now smaller:


diff --git a/chrome/renderer/devtools_agent.cc
b/chrome/renderer/devtools_agent.cc
index 5adfa09..01c66e4 100644
--- a/chrome/renderer/devtools_agent.cc
+++ b/chrome/renderer/devtools_agent.cc
@@ -195,9 +195,3 @@ WebDevToolsAgent* DevToolsAgent::GetWebAgent() {
     return NULL;
   return web_view->devToolsAgent();
 }
-
-// static
-void WebKit::WebDevToolsAgentClient::sendMessageToFrontendOnIOThread(
-    const WebDevToolsMessageData& data) {
-  DevToolsAgentFilter::SendRpcMessage(DevToolsMessageData(data));
-}
diff --git a/chrome/renderer/devtools_agent_filter.cc
b/chrome/renderer/devtools_agent_filter.cc
index 5eb54ed..4c98cbe 100644
--- a/chrome/renderer/devtools_agent_filter.cc
+++ b/chrome/renderer/devtools_agent_filter.cc
@@ -64,8 +64,21 @@ void DevToolsAgentFilter::OnDebuggerPauseScript() {
   WebDevToolsAgent::debuggerPauseScript();
 }
 
+namespace {
+
+class WebDevToolsMessageTransportImpl : public
WebKit::WebDevToolsMessageTransport {
+ public:
+  void sendMessageToFrontendOnIOThread(const WebKit::WebDevToolsMessageData&
data) {
+    DevToolsAgentFilter::SendRpcMessage(DevToolsMessageData(data));
+  }
+};
+
+}  // namespace
+
 void DevToolsAgentFilter::OnRpcMessage(const DevToolsMessageData& data) {
+  WebDevToolsMessageTransportImpl transport;
   message_handled_ = WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread(
+      &transport,
       data.ToWebDevToolsMessageData());
 }