[webkit-reviews] review denied: [Bug 31295] [Qt] Rendering of html select elements is broken : [Attachment 58775] revert r49242

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 02:05:11 PDT 2010


Tor Arne Vestbø <vestbo at webkit.org> has denied	review:
Bug 31295: [Qt] Rendering of html select elements is broken
https://bugs.webkit.org/show_bug.cgi?id=31295

Attachment 58775: revert r49242
https://bugs.webkit.org/attachment.cgi?id=58775&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
> +    // The invalid WebCore::Color is conveniently transparent, so in many
contexts you can just use it without checking for validity.
> +    return QColor(red(), green(), blue(), alpha());

This is wrong, in the Qt context is is not transparent, so we cant use it
without checking for validity, we have to keep the check to make the guards
from r58949 catch it.


More information about the webkit-reviews mailing list