[webkit-reviews] review canceled: [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data. : [Attachment 58821] Patch

[bugzilla-daemon at webkit.org]

Daniel Cheng <dcheng at chromium.org> has canceled Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 40540: [chromium] Add new stubs for querying platform drag-and-drop and
copy-and-paste data.
https://bugs.webkit.org/show_bug.cgi?id=40540

Attachment 58821: Patch
https://bugs.webkit.org/attachment.cgi?id=58821&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #20)
> (In reply to comment #17)
> > > WebKit/chromium/public/WebKitClient.h:90
> > >  +      virtual bool clipboardWriteData(const WebDragData& data) { return
false; }
> > > shouldn't this method be declared on WebClipboard instead?  that
> > > interface exists to collect all of the clipboard related callbacks
> > > to the embedder.
> > > 
> > 
> > Why do we go through all that indirection? I find it hard to follow
personally:
> > ChromiumBridge->WebKitClient->WebClipboard->WebClipboardImpl->renderer
glue, which in the end, just calls an IPC. Is this for the test shell?
> > 
> > Isn't it simpler to just say:
> > ChromiumBridge->WebKitClient->IPC?
> 
> It helps provide some grouping to WebKitClient.  I think it would
> become a giant mess to have everything flattened into a single
> implementation.
> 

Done.