[webkit-reviews] review granted: [Bug 40622] Fix return values of functions returning bool instead of pointer : [Attachment 58779] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 15 13:47:39 PDT 2010


David Levin <levin at chromium.org> has granted Lucas De Marchi
<lucas.demarchi at profusion.mobi>'s request for review:
Bug 40622: Fix return values of functions returning bool instead of pointer
https://bugs.webkit.org/show_bug.cgi?id=40622

Attachment 58779: Patch
https://bugs.webkit.org/attachment.cgi?id=58779&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index
caf28db0f3ab1d011b49ab785eea0623352db82f..9d744124996a7431e9b4f2ff81ed67a52061c
e58 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,17 @@
> +2010-06-15  Lucas De Marchi	<lucas.demarchi at profusion.mobi>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Return 0 instead of false when functions return a pointer instead of

> +	   a boolean value.
> +	   https://bugs.webkit.org/show_bug.cgi?id=40622
> +
> +	   No new tests since this just removes compiler warnings.

Typically you'd say "No change in functionality so no new tests."


More information about the webkit-reviews mailing list