[webkit-reviews] review granted: [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods. : [Attachment 58778] Fix to remove the use of color() and fixes a crash in the tests

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Alex Milowski
<alex at milowski.com>'s request for review:
Bug 40327: Leftover calls to RenderStyle color accessors, which are no longer
public methods.
https://bugs.webkit.org/show_bug.cgi?id=40327

Attachment 58778: Fix to remove the use of color() and fixes a crash in the
tests
https://bugs.webkit.org/attachment.cgi?id=58778&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 61186)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2010-06-15  Alex Milowski  <alex at milowski.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fixed a compile error in the paint() methods by making them	use the


Extra space after them.

> +	   new visitedDependentColor() method.

Please add bug link.

> +
> +	   Fixed a crash in RenderMathMLRoot with the tests where there were 
> +	   bad assumptions about the children in the layout.

This would be better as a function comment (for RenderMathMLRoot::layout).