[webkit-reviews] review requested: [Bug 39195] Spatial Navigation: refactor scrollInDirection to work with scrollable content : [Attachment 58787] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 15 09:37:09 PDT 2010


Antonio Gomes <tonikitoo at webkit.org> has asked	for review:
Bug 39195: Spatial Navigation: refactor scrollInDirection to work with
scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Attachment 58787: patch v2
https://bugs.webkit.org/attachment.cgi?id=58787&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
Patch ready for review.

Summary: Patch changes the scrollInDirection method to receives as parameter
the node that the spatial navigation
found as the one more appropriated to move focus to. If it is in a scrollable
container (e.g. <div> with clipped overflow content), it scrolls recursively
starting from the container, not the current focused node.

This is a follow up on bug 39217.


More information about the webkit-reviews mailing list