[webkit-reviews] review requested: [Bug 38988] Avoid to store the beginning of the match on the stack in Yarr JIT : [Attachment 55838] proposed patch

[bugzilla-daemon at webkit.org]

Peter Varga <pvarga at inf.u-szeged.hu> has asked	for review:
Bug 38988: Avoid to store the beginning of the match on the stack in Yarr JIT
https://bugs.webkit.org/show_bug.cgi?id=38988

Attachment 55838: proposed patch
https://bugs.webkit.org/attachment.cgi?id=55838&action=review

------- Additional Comments from Peter Varga <pvarga at inf.u-szeged.hu>
We don't need to do this allocation on stack, so this patch solves the removed
TODO. It saves sizeof(int) bytes from stack per matching.
In fact, this patch doesn't even have effect on performance, it improves the
memory usage. 
Btw, the performance results are:

	       ref		  mod
regexp-dna: 22.4ms +/- 1.6%    22.4ms +/- 1.6%
v8-regexp:  445.9ms +/- 2.6%   444.5ms +/- 2.6%

I set to r? again.