[webkit-reviews] review canceled: [Bug 36128] [Gtk] nameFromChildren is obsolete : [Attachment 58479] new layout test which should work fine

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 36128: [Gtk] nameFromChildren is obsolete
https://bugs.webkit.org/show_bug.cgi?id=36128

Attachment 58479: new layout test which should work fine
https://bugs.webkit.org/attachment.cgi?id=58479&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #11)
> [...]
> My first priority for tomorrow morning is to work on this bug and try a 
> suggestion coming from Martin Robinson that could help a lot to get a more 
> general solution, let's see if it works (hope so!)

I've tried mrobinson's suggestion[*] but couldn't get it working with changes
in DRT only: I always needed anyway some timeouts to ensure layout() has been
called when asking for the title of the <label> element.

Hence, I'm now attaching a combined patch with Joanmarie's patch + the new
test, where I tried to reduce those timeouts to a minimum (while reasonable)
value.

Let's see if we can get some review on this then and perhaps some advice to
get, if possible, a more general solution (perhaps I was doing something wrong
wrt mrobinson's suggestion).

> Once I'm done with this, next step would be bug 30869. Let'see if we can get 

> rid of these two once and for all in a row! :-)

I'll step into this one now, while waiting for review on this combined patch.

[*]  Try to call to webkit_web_frame_layout() before dumping the tree