[webkit-reviews] review requested: [Bug 40112] Database callbacks are made using the ScriptExecutionContext of the frame that owns the Database object, rather than that of the caller : [Attachment 58754] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 40112: Database callbacks are made using the ScriptExecutionContext of the
frame that owns the Database object, rather than that of the caller
https://bugs.webkit.org/show_bug.cgi?id=40112

Attachment 58754: patch
https://bugs.webkit.org/attachment.cgi?id=58754&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Andrei, Jeremy: please take a look at the patch and let me know if I completely
misunderstood what this bug is about.

Adam: assuming I understood correctly what the problem is, can you please take
a careful look at this patch? In particular, I'm concerned about
ASSERT(m_scriptExecutionContext) in handleEvent() in the JSC callbacks. It
seems to me that it's possible for the context that created the callback to go
away before we get a chance to call the callback. In that case, should the
ASSERT be replaced with something like "if (!m_scriptExecutionContext) return
true;"? Or just remove the ASSERT and move the check inside
toJSDOMGlobalObject()? Same question for ASSERT(m_data).