[webkit-reviews] review granted: [Bug 40596] Safari beach-balls loading large pages with HTML5 parser : [Attachment 58725] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 40596: Safari beach-balls loading large pages with HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40596

Attachment 58725: Patch
https://bugs.webkit.org/attachment.cgi?id=58725&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Minor nits.  Don't know how to test this code...  :(

WebCore/html/HTML5DocumentParser.cpp:51
 +  // FIXME: We would this to be 0.2. Historically .2 caused slowness on old
machines.
0.2 / .2 consistency.

WebCore/html/HTML5DocumentParser.cpp:129
 +  bool HTML5DocumentParser::processingData() const
WTF.  Please add a FIXME to track this down and figure out what it does.

WebCore/html/HTML5DocumentParser.cpp:174
 +	session.processedTokens++;
prefix increment

WebCore/html/HTML5DocumentParser.cpp:192
 +		return;
This is supposed to be break, not return

WebCore/html/HTML5DocumentParser.cpp:220
 +  // FIXME: This belongs on Document.
Please add this to document.

WebCore/html/HTML5DocumentParser.cpp:230
 +	// HACK: If a layout is scheduled, wait again to let the layout timer
run first.
Is this copied from the old document parser?

WebCore/html/HTML5DocumentParser.cpp:278
 +	SynchronousMode mode = isFromNetwork ? AllowYield : ForceSynchronous;
Please inline this into call site.