[webkit-reviews] review granted: [Bug 37851] [GTK] Does not compile with -DGSEAL_ENABLE : [Attachment 58689] gseal.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 15:19:49 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 37851: [GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Attachment 58689: gseal.diff
https://bugs.webkit.org/attachment.cgi?id=58689&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Looks good to me, with the following comments:

WebKit/gtk/tests/testdomnode.c:164
 +	g_assert(webkit_dom_node_has_child_nodes(WEBKIT_DOM_NODE(body)) ==
FALSE);
oops =)

WebKit/gtk/webkit/webkitwebview.cpp:834
 +	gdk_window_set_user_data(gtk_widget_get_window(widget), widget);
Might be worth saving the call to get here by using a variable?
Micro-optimization, but it doesn't get less readable.

WebKit/gtk/webkit/webkitwebview.cpp:845
 +	gtk_im_context_set_client_window(priv->imContext,
gtk_widget_get_window(widget));
One more call saved! yay hehe


More information about the webkit-reviews mailing list