[webkit-reviews] review denied: [Bug 40544] [Chromium] Add stubs for OOP font loading to Chromium WebKit API on OSX. : [Attachment 58590] patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 14 11:46:33 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 40544: [Chromium] Add stubs for OOP font loading to Chromium WebKit API on
OSX.
https://bugs.webkit.org/show_bug.cgi?id=40544
Attachment 58590: patch 1
https://bugs.webkit.org/attachment.cgi?id=58590&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/platform/chromium/ChromiumBridge.h:143
+ #endif
nit: please add a new line after the #endif
WebKit/chromium/src/ChromiumBridge.cpp:410
+ return ss ? ss->loadFont(srcFont, out) : true;
why return true when there is no sandbox support? shouldn't you also do |*out
= 0;| before returning?
WebCore/platform/chromium/ChromiumBridge.h:50
+
nit: no need for this new line here. it is nice to keep the OS(DARWIN)
block as one contiguous block since it is fairly small.
More information about the webkit-reviews
mailing list