[webkit-reviews] review denied: [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods. : [Attachment 58257] Revised patch to get RenderMathMLRoot and RenderMathMLSquareRoot to build after rev. 59956.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 11:27:26 PDT 2010


David Levin <levin at chromium.org> has denied Clemmitt Sigler
<cmsigler at gmail.com>'s request for review:
Bug 40327: Leftover calls to RenderStyle color accessors, which are no longer
public methods.
https://bugs.webkit.org/show_bug.cgi?id=40327

Attachment 58257: Revised patch to get RenderMathMLRoot and
RenderMathMLSquareRoot to build after rev. 59956.
https://bugs.webkit.org/attachment.cgi?id=58257&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Please consider Alex's suggestion. I guess the better fix is to get rid of the
dependency that is causing these to be "friend class".

PS I suspect this part of the comment is incorrect "Rebaselining should be
performed to remove this."


More information about the webkit-reviews mailing list