[webkit-reviews] review granted: [Bug 40565] [WebKitSite] Improve assertion macro documentation : [Attachment 58637] Improve assertion documentation

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 40565: [WebKitSite] Improve assertion macro documentation
https://bugs.webkit.org/show_bug.cgi?id=40565

Attachment 58637: Improve assertion documentation
https://bugs.webkit.org/attachment.cgi?id=58637&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
These changes look good.

I think that it’s overstating the case to say that out of memory errors are not
recoverable. Maybe there’s a more nuanced way to talk about this. Because of
virtual memory systems we program assuming we will not run out of memory for
small allocation, and we don't wish to rewrite all the code to handle
out-of-memory errors. In those cases we want to terminate the program if we
can’t get the memory. But we do have functions that return 0 if there is not
sufficient memory. We tend to use those for larger allocations that might fail
in practice even if the program has ample space to continue.

The topic is generally subtle and just stating that memory errors are
unrecoverable is imprecise.