[webkit-reviews] review denied: [Bug 35187] Web Inspector: can resize the main window to be smaller than the minimum docked height : [Attachment 58598] [PATCH] proposed patch v0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 01:41:51 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Juan C. Montemayor E
<jmonte03 at cs.tufts.edu>'s request for review:
Bug 35187: Web Inspector: can resize the main window to be smaller than the
minimum docked height
https://bugs.webkit.org/show_bug.cgi?id=35187

Attachment 58598: [PATCH] proposed patch v0
https://bugs.webkit.org/attachment.cgi?id=58598&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This is an arguable change since resizing window to be smaller than minimum and
restoring its original size would leave inspector undocked. In fact, I don't
see anything critical in having inspector less than 250 pixels in height. We
just need to make sure that inspector toolbar is visible so that the user was
not confused.

On the technical side of the change, I'd rather track inspected window size
from within native code. Front-end code should not be responsible for the
embedder's window size policy.


More information about the webkit-reviews mailing list