[webkit-reviews] review denied: [Bug 35350] DumpRenderTree should allow tests with modal dialogs : [Attachment 57603] Patch to add a showModalDialog support for DumpRenderTree on Mac

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Prasad Tammana
<prasadt at chromium.org>'s request for review:
Bug 35350: DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Attachment 57603: Patch to add a showModalDialog support for DumpRenderTree on
Mac
https://bugs.webkit.org/attachment.cgi?id=57603&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    [m_webView performSelector:@selector(_closeWindow) withObject:nil
afterDelay:0.0];
> +    [m_webView performSelector:@selector(_closeWindow) withObject:nil
afterDelay:0.0
> +	   inModes:[NSArray arrayWithObjects:NSDefaultRunLoopMode,
NSModalPanelRunLoopMode,
> +		    NSConnectionReplyMode, NSEventTrackingRunLoopMode, nil]];

This change is not needed to make showModalDialog work in DumpRenderTree.
Making this change could affect the behavior of applications on Mac and so the
decision of whether to change it should not be driven by the needs of our test
tool alone.

The rest of the patch seems OK.