[webkit-reviews] review granted: [Bug 39941] Deploy adoptRef in more places, including all HTML and MathML elements : [Attachment 58599] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 13 14:41:03 PDT 2010


David Levin <levin at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 39941: Deploy adoptRef in more places, including all HTML and MathML
elements
https://bugs.webkit.org/show_bug.cgi?id=39941

Attachment 58599: Patch
https://bugs.webkit.org/attachment.cgi?id=58599&action=review

------- Additional Comments from David Levin <levin at chromium.org>
WebCore/editing/ModifySelectionListLevel.cpp:218
 +	return command->m_listElement;
(I know it is the same code as before but) It would be nice to make this
"return command->m_listElement.release();"


WebCore/mathml/MathMLMathElement.cpp:47
 +  RenderObject* MathMLMathElement::createRenderer(RenderArena* arena,
RenderStyle* style)
I don't really understand why this change was done.

Also, I don't know what this has to do with "Deploy adoptRef in more place". (I
suspect it was just some additional clean up. I suspect that if it is worth
doing, then most of the MathML*Element classes should have this done and that
could be a change by itself.)

In short, feel free to leave this in the change (but it would be nice to have
the "Why?" answered).


More information about the webkit-reviews mailing list