[webkit-reviews] review requested: [Bug 40005] [Qt] Platform plugin support for Notifications UI : [Attachment 58596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 13 10:56:48 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 40005: [Qt] Platform plugin support for Notifications UI
https://bugs.webkit.org/show_bug.cgi?id=40005

Attachment 58596: Patch
https://bugs.webkit.org/attachment.cgi?id=58596&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Address comment #13, with the exception that I don't make a local copy of the
strings (as said in comment #14).
I agree that the name NotificationIconWrapper does not reflect its purpose
anymore.
Originally, I wanted it to only wrap QSystemTrayIcon, but now it does much
more.
How about renaming it NotificationWrapper?
However, let's rename it in a separate patch, because this one just keeps
growing :-)


More information about the webkit-reviews mailing list