[webkit-reviews] review denied: [Bug 40380] [Qt] When a layer is really opaque (ie has a background color that has 255 alpha) we should fill the layer with that color to tell Qt that the pixemap has no alpha. : [Attachment 58558] Proposed patch with proper coding style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 13 07:40:25 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40380: [Qt] When a layer is really opaque (ie has a background color that
has 255 alpha) we should fill the layer with that color to tell Qt that the
pixemap has no alpha.
https://bugs.webkit.org/show_bug.cgi?id=40380

Attachment 58558: Proposed patch with proper coding style
https://bugs.webkit.org/attachment.cgi?id=58558&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Can't we get a test case for this?

r- due to missing test case and because you should do the style clean up in a
separate patch.


More information about the webkit-reviews mailing list