[webkit-reviews] review canceled: [Bug 29244] undefined reference errors when linking due to gperf and inlining : [Attachment 56587] centralize gperf usage

[bugzilla-daemon at webkit.org]

Andras Becsi <abecsi at webkit.org> has canceled  review:
Bug 29244: undefined reference errors when linking due to gperf and inlining
https://bugs.webkit.org/show_bug.cgi?id=29244

Attachment 56587: centralize gperf usage
https://bugs.webkit.org/attachment.cgi?id=56587&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
(In reply to comment #45)
> (From update of attachment 56587 [details])
> Seems OK. Not obviously a big improvement, but I suppose we can all adopt the
build style the Chrome team decided on instead of using the make file. I'm a
bit sad, though, because originally DerivedSources.make was going to be shared
by all build systems. It seems that dream has died!

Thanks a lot Darin. First half landed in r61091.

After working on it a bit more I'll submit the second half which should fix the
linking.