[webkit-reviews] review denied: [Bug 39492] QtWebkit fails to load http://upg.de, because MIME type is TEXT/HTML : [Attachment 58113] patch_v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 12 20:52:46 PDT 2010
Eric Seidel <eric at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 39492: QtWebkit fails to load http://upg.de, because MIME type is TEXT/HTML
https://bugs.webkit.org/show_bug.cgi?id=39492
Attachment 58113: patch_v2
https://bugs.webkit.org/attachment.cgi?id=58113&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
MIMEType as an argument name violates the style guidelines. We shoudl fix that
to mimeType while here. Otherwise looks fine.
I'm slightly surprised this isn't already tested, but I'm glad you added a
test.
The tests appear to be copied twice. r- for that at least.
More information about the webkit-reviews
mailing list