[webkit-reviews] review denied: [Bug 40464] [chromium] Clicking a login input field should open a popup with the saved logins : [Attachment 58452] First version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 19:50:02 PDT 2010


Kent Tamura <tkent at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 40464: [chromium] Clicking a login input field should open a popup with the
saved logins
https://bugs.webkit.org/show_bug.cgi?id=40464

Attachment 58452: First version
https://bugs.webkit.org/attachment.cgi?id=58452&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebKit/chromium/public/WebPasswordAutocompleteListener.h:52
 +	virtual bool showSuggestionPopup(const string16& value) = 0;
We should use WebString instead of string16 for WebKit API.


More information about the webkit-reviews mailing list