[webkit-reviews] review denied: [Bug 40307] [GTK] DragDataGtk should use DataObjectGtk as the platformDragData : [Attachment 58161] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 19:06:04 PDT 2010


Eric Seidel <eric at webkit.org> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 40307: [GTK] DragDataGtk should use DataObjectGtk as the platformDragData
https://bugs.webkit.org/show_bug.cgi?id=40307

Attachment 58161: Patch
https://bugs.webkit.org/attachment.cgi?id=58161&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/platform/DragData.h: 
 +  typedef void* DragDataRef;
Can't this just be class DataObjectGtk; instead of having to include the
header?

WebCore/platform/gtk/DragDataGtk.cpp:93
 +	RefPtr<DocumentFragment> fragment(createFragmentFromMarkup(document,
m_platformDragData->markup(), ""));
Why store this in a ref ptr at all?


More information about the webkit-reviews mailing list