[webkit-reviews] review granted: [Bug 39826] Reenable IDBDatabaseRequest's description attribute : [Attachment 57884] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 18:53:49 PDT 2010


Darin Adler <darin at apple.com> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 39826: Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

Attachment 57884: Patch
https://bugs.webkit.org/attachment.cgi?id=57884&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	       if ($attributeName eq "id" or $attributeName eq "hash") {
> -		   # Special case attributes id and hash to be idName and
hashName to avoid ObjC naming conflict.
> +	       if ($attributeName eq "id" or $attributeName eq "hash" or
$attributeName eq "description") {
> +		   # Special case some attributes (like id and hash) to have a
"Name" suffix to avoid ObjC naming conflicts.

Seems like we should use a Perl function for this now that it's getting to be a
larger number of names than just two.


More information about the webkit-reviews mailing list