[webkit-reviews] review granted: [Bug 29244] undefined reference errors when linking due to gperf and inlining : [Attachment 56587] centralize gperf usage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 18:26:06 PDT 2010


Darin Adler <darin at apple.com> has granted Andras Becsi <abecsi at webkit.org>'s
request for review:
Bug 29244: undefined reference errors when linking due to gperf and inlining
https://bugs.webkit.org/show_bug.cgi?id=29244

Attachment 56587: centralize gperf usage
https://bugs.webkit.org/attachment.cgi?id=56587&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems OK. Not obviously a big improvement, but I suppose we can all adopt the
build style the Chrome team decided on instead of using the make file. I'm a
bit sad, though, because originally DerivedSources.make was going to be shared
by all build systems. It seems that dream has died!


More information about the webkit-reviews mailing list