[webkit-reviews] review granted: [Bug 38180] Remove unneeded custom code for WebSocket.send : [Attachment 54473] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 12 17:59:48 PDT 2010


Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38180: Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Attachment 54473: Patch
https://bugs.webkit.org/attachment.cgi?id=54473&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // FIXME: RequiresAllArguments is likely bogus here.

I think we should find a better way to keep track of these. I am not sure these
“is likely bogus” comments are useful.

> +	   [RequiresAllArguments] boolean send(in DOMString data)
> +	       raises(DOMException);

I prefer the "all in one line" style for these.


More information about the webkit-reviews mailing list