[webkit-reviews] review granted: [Bug 40497] do-webcore-rename should have a --verbose option : [Attachment 58509] Fixed --help support per wms's comment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 12 10:22:25 PDT 2010
Daniel Bates <dbates at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 40497: do-webcore-rename should have a --verbose option
https://bugs.webkit.org/show_bug.cgi?id=40497
Attachment 58509: Fixed --help support per wms's comment
https://bugs.webkit.org/attachment.cgi?id=58509&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
> - if ($file =~ /^\../) {
> + # Ignore excluded and hidden files/directories.
> + if ($directoriesToIgnore{$file} or $file =~ /^\../ or $file =~
/^ChangeLog/) {
> + print "Ignoring $File::Find::name\n" if $verbose;
> $File::Find::prune = 1;
As far as I can tell, $File::Find::prune only makes sense with respects to
directories (to prevent descending into a directory), but I don't anticipate
any issues with setting this on a file, say the ChangeLog files.
> return;
r=me.
More information about the webkit-reviews
mailing list