[webkit-reviews] review granted: [Bug 40503] Fix various warnings that are reported when building with clang : [Attachment 58528] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 11 16:53:24 PDT 2010
Eric Seidel <eric at webkit.org> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 40503: Fix various warnings that are reported when building with clang
https://bugs.webkit.org/show_bug.cgi?id=40503
Attachment 58528: patch
https://bugs.webkit.org/attachment.cgi?id=58528&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/bindings/v8/NPV8Object.cpp:
+ static WrapperTypeInfo typeInfo = { 0, 0, false };
Can't we just change the expected type to be a bool? That would be cleaner.
Otherwise looks fine.
More information about the webkit-reviews
mailing list