[webkit-reviews] review granted: [Bug 40324] [Qt] DRT EventSender support to graphics context events : [Attachment 58490] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 40324: [Qt] DRT EventSender support to graphics context events
https://bugs.webkit.org/show_bug.cgi?id=40324

Attachment 58490: Patch
https://bugs.webkit.org/attachment.cgi?id=58490&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp:347
 +	    WebCore::WebViewGraphicsBased* view =
qobject_cast<WebCore::WebViewGraphicsBased*>(m_page->view());
as you sure this is right? We normally do not set the view when dealing with
QGraphicsWebView. And even if you set it, it seems like a hack. It would be
nice to do this in another way

Anyway, looks fine.