[webkit-reviews] review denied: [Bug 36903] Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter : [Attachment 58416] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 36903: Implement BlobBuilder internal class for BlobBuilder support as
defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

Attachment 58416: Patch
https://bugs.webkit.org/attachment.cgi?id=58416&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Some more comments.

WebCore/html/Blob.h:44
 +	static PassRefPtr<Blob> create(const String type, const BlobItemList&
items)
"const String" in create() is inconsistent with "const String&" in Blob().

WebCore/html/Blob.h:73
 +	Blob() { }
Is this needed?

WebCore/html/BlobBuilder.h:40
 +  #include <wtf/Vector.h>
This seems not to be needed.

WebCore/html/BlobBuilder.h:57
 +	BlobBuilder();
We do not really need this default constructor.