[webkit-reviews] review granted: [Bug 40435] [v8] Introduce single element caches for WebCore::String to v8::String conversions : [Attachment 58488] Restore isMainThread assertion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 11:13:25 PDT 2010


Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 40435: [v8] Introduce single element caches for WebCore::String to
v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435

Attachment 58488: Restore isMainThread assertion
https://bugs.webkit.org/attachment.cgi?id=58488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
> Regarding MainThread.  I just speculative fetch the map in any thread.

I see.	I'd have to looking into it more carefully to see whether that's safe. 
If it doesn't have a big perf impact, it might be netter to leave the assert in
so the code is easier to understand.


More information about the webkit-reviews mailing list