[webkit-reviews] review granted: [Bug 40435] [v8] Introduce single element caches for WebCore::String to v8::String conversions : [Attachment 58396] First version

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 40435: [v8] Introduce single element caches for WebCore::String to
v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435

Attachment 58396: First version
https://bugs.webkit.org/attachment.cgi?id=58396&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Cool.

WebCore/bindings/v8/V8Binding.cpp: 
 +	ASSERT(WTF::isMainThread());
I didn't quite understand the reasoning behind remove this assert.  I'm not
necessarily against it, I just don't understand.

WebCore/bindings/v8/V8Binding.h:84
 +	// Note: RefPtr is a must as we cache by StringImpl* equality, not
identity
I don't quite understand the difference between equality and identity, but it
makes sense to me why we need a RefPtr here.