[webkit-reviews] review granted: [Bug 40374] Client-based Geolocation does not pass high power option to controller and client : [Attachment 58467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 10:30:32 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 40374: Client-based Geolocation does not pass high power option to
controller and client
https://bugs.webkit.org/show_bug.cgi?id=40374

Attachment 58467: Patch
https://bugs.webkit.org/attachment.cgi?id=58467&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> -    HashSet<RefPtr<Geolocation> > m_observers;
> +    typedef HashMap<RefPtr<Geolocation>, bool> ObserversMap;

It feels a little strange that of all PositionOptions, only this one goes here.
But I guess that's the way it is.

r=me.


More information about the webkit-reviews mailing list