[webkit-reviews] review granted: [Bug 40429] REGRESSION: Can't submit a form with <input type=radio required> : [Attachment 58462] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 08:38:39 PDT 2010


Darin Adler <darin at apple.com> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 40429: REGRESSION: Can't submit a form with <input type=radio required>
https://bugs.webkit.org/show_bug.cgi?id=40429

Attachment 58462: Patch 2
https://bugs.webkit.org/attachment.cgi?id=58462&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       if (element->formControlType() != formControlType())
> +		   continue;
> +	       if (element->formControlName() != formControlName())
> +		   continue;

I think you can use type() and name() on the right side of these if statements.
Since we're doing this work for every element in the entire document I think
you need to be careful to use the check that is most likely to fail first.
That's probably the formControlName() check.


More information about the webkit-reviews mailing list