[webkit-reviews] review denied: [Bug 40420] Web Inspector: Prevent from copying "filename.css" in Styles pane : [Attachment 58382] Uncopyable subtitle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 06:03:14 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Nikita Vasilev <me at elv1s.ru>'s
request for review:
Bug 40420: Web Inspector: Prevent from copying "filename.css" in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=40420

Attachment 58382: Uncopyable subtitle
https://bugs.webkit.org/attachment.cgi?id=58382&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Couple of nits.

WebCore/inspector/front-end/Section.js:86
 +	    if (x instanceof Node) {
I don't think we should extend section's api to accept both text and Nodes as
subtitles. subtitle setter is a convenience method for setting text. Should
client need greater extensibility, he is free to access subtitleElement
explicitly.

WebCore/inspector/front-end/StylesSidebarPane.js:654
 +		    var link = WebInspector.linkifyResourceAsNode(url,
"resources", this.rule.sourceLine + 1);
So I would leave this code as is with appending child here as it used to be.

WebCore/inspector/front-end/inspector.css:4041
 +  .styles-section .header [data-uncopyable]::before {
You should just apply this to ".styles-section .subtitle".


More information about the webkit-reviews mailing list