[webkit-reviews] review denied: [Bug 40301] DOM storage should only create databases when needed : [Attachment 58233] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied hans at chromium.org's request for
review:
Bug 40301: DOM storage should only create databases when needed
https://bugs.webkit.org/show_bug.cgi?id=40301

Attachment 58233: Patch
https://bugs.webkit.org/attachment.cgi?id=58233&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/ChangeLog:8
 +	    As soon as a page attempts to use localstorage, StorageAreaSync
will create an empty database if one doesn't already exist. This can lead to
lots of unnecessary database files. In particular, they are created even when
the privacy settings or private browsing mode disallow localstorage data, which
may seem odd to the user.
This is all on one line.  Please wrap.

WebCore/manual-tests/localstorage-empty-database.html:6
 +  </body>
Why end the body before the body?  :-)

WebCore/storage/StorageAreaSync.cpp:203
 +  void StorageAreaSync::openDatabase(OpenDatabaseParamType create)
Create is probably not the best name for this.