[webkit-reviews] review requested: [Bug 23588] Add inputmode attribute support, as per XHTML Basic 1.1 : [Attachment 58455] Resubmission after addressing reviewer's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 02:12:46 PDT 2010


Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 23588: Add inputmode attribute support, as per XHTML Basic 1.1
https://bugs.webkit.org/show_bug.cgi?id=23588

Attachment 58455: Resubmission after addressing reviewer's comments
https://bugs.webkit.org/attachment.cgi?id=58455&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
Thanks Kent for the review .

Resubmitting following Kent's comments,  with the following comments:


1. Removed the HTMLTextFormControlElement::inputmode() and
HTMLTextFormControlElement::setInputmode(), and add modifier "Reflect" in the
idl file of HTMLInputElement and HTMLTextAreaInput so that we don't need to
define inputmode() and setInputmode() 

2. The test cases will be automatically skipped by unsupported platforms, we
don't need to add them to skip files.


More information about the webkit-reviews mailing list