[webkit-reviews] review granted: [Bug 40315] Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION : [Attachment 58386] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 21:33:07 PDT 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Zhenyao Mo
<zmo at google.com>'s request for review:
Bug 40315: Vertex attributes enabled as arrays but not bound to buffers must
generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=40315

Attachment 58386: patch
https://bugs.webkit.org/attachment.cgi?id=58386&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok, with a clean-up suggestion:

WebCore/html/canvas/WebGLRenderingContext.cpp:2936
 +	m_vertexAttribState[indx].bufferBinding = m_boundArrayBuffer;
Typically, we try not to abbreviate names.


More information about the webkit-reviews mailing list