[webkit-reviews] review denied: [Bug 40452] REGRESSION: printing is broken if stylesheet has @page : [Attachment 58441] Fix Bug 40452: REGRESSION: printing is broken if stylesheet has @page

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has denied Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 40452: REGRESSION: printing is broken if stylesheet has @page
https://bugs.webkit.org/show_bug.cgi?id=40452

Attachment 58441: Fix Bug 40452: REGRESSION: printing is broken if stylesheet
has @page
https://bugs.webkit.org/attachment.cgi?id=58441&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
WebCore/css/CSSStyleSelector.cpp:2795
 +			    if (childItem->isPageRule()) {
Cannot we create a function to do this so we can share code?

WebCore/ChangeLog:8
 +	    No new tests because currently there is no easy way to test print
layout.
I'm not 100% sure, but I guess we can test this patch by setPrinting though
pixel dump isn't supported yet.