[webkit-reviews] review denied: [Bug 40417] HTML5Tokenizer needs to tell the InspectorTimelineAgent before and after it writes : [Attachment 58359] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 10:16:36 PDT 2010


Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 40417: HTML5Tokenizer needs to tell the InspectorTimelineAgent before and
after it writes
https://bugs.webkit.org/show_bug.cgi?id=40417

Attachment 58359: Patch
https://bugs.webkit.org/attachment.cgi?id=58359&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
http://wkrietveld.appspot.com/40417/diff/1/3
File WebCore/html/HTML5Tokenizer.cpp (right):

http://wkrietveld.appspot.com/40417/diff/1/3#newcode160
WebCore/html/HTML5Tokenizer.cpp:160: willWriteHTML(source);
Are we supposed to call this when appendData is true?  If so, why don't we call
when write() is nested and appendData is true?


More information about the webkit-reviews mailing list