[webkit-reviews] review canceled: [Bug 40364] Web Inspector: don't push script sources to frontend if scripts panel is inactive : [Attachment 58378] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 10 09:55:29 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has canceled Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 40364: Web Inspector: don't push script sources to frontend if scripts
panel is inactive
https://bugs.webkit.org/show_bug.cgi?id=40364
Attachment 58378: Patch
https://bugs.webkit.org/attachment.cgi?id=58378&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorBackend.h:94
+ void resolveScriptSource(long callId, const String& sourceID);
getScriptSource? There is not much to resolve there...
WebCore/inspector/InspectorController.cpp:1698
+ String dataToSend =
ScriptDebugServer::shared().isDebuggerAlwaysEnabled() ? "" : data;
Can we make it always lazy regardless the setting?
More information about the webkit-reviews
mailing list