[webkit-reviews] review requested: [Bug 23588] Add inputmode attribute support, as per XHTML Basic 1.1 : [Attachment 58364] patch for XHTML Basic 1.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 04:49:07 PDT 2010


Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 23588: Add inputmode attribute support, as per XHTML Basic 1.1
https://bugs.webkit.org/show_bug.cgi?id=23588

Attachment 58364: patch for XHTML Basic 1.1
https://bugs.webkit.org/attachment.cgi?id=58364&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch is to add the XHTML Basic 1.1 support (conditionally with
ENABLE_XHTMLBASIC), specifically, inputmethod support.

Attribute "inputmethod" for "input" and "textarea" element servers as a input
method hint, so that we the control is in focus, the system automatically
switchs to the input method indicated by "inputmethod" attribute.

This applies to most mobile devices which have limited input hardware, and need
to switch between input methods to take advantage of limited hardware input
capabilities.  The inputmode helps to facilitate the input method switching,
otherwise, the user has to manually switches to the right input method.

The inputmode is only a "hint", or suggestion, for the input method, it doesn't
prevent the user from switching to other input methods manually, as they like,
and it doesn't validate the acutally input from the user.

The patch addresses the WebCore part of this feature, and each porting need to
implement a platform-specific interface to actually switch the input method,
this can be done in an existing interface: 
EditorClient::setInputMethodState(bool).

Before this patch, EditorClient::setInputMethodState(bool) only
enables/disables the input method, automatically when the focus is on text node
/ non-text node.  The implementation of this API should also be responsible for
switching to the right Input Method based on the inputmode value, so we are not
going to  introduce a new API for EditorClient.

The patch contains a reference code in for QT, other portings can do similar to
switch the Input Methods based on inputmode value.


More information about the webkit-reviews mailing list