[webkit-reviews] review canceled: [Bug 40400] Refactoring: Simple shadow elements should be factored out . : [Attachment 58335] patch v1; fixed style violation

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled MORITA Hajime
<morrita at google.com>'s request for review:
Bug 40400: Refactoring: Simple shadow elements should be factored out .
https://bugs.webkit.org/show_bug.cgi?id=40400

Attachment 58335: patch v1; fixed style violation
https://bugs.webkit.org/attachment.cgi?id=58335&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
This is a good refactoring.

Please check if we can share code with
rendering/TextControllInnerElements.{cpp,h} too.


WebCore/WebCore.xcodeproj/project.pbxproj:21765
 +				A7E5D1D111C0AE25000A338E /* ShadowElement.cpp
in Sources */,
We should sort lists in project.pbxproj.
As you saw, the current pbxproj is not sorted correctly.  So you might want to
run WebKitTools/Scripts/sort-Xcode-project-file before this change.