[webkit-reviews] review denied: [Bug 40397] [Chromium] Add the ability to specify a separator in AutoFillPopupMenuChromium : [Attachment 58316] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Hawkins
<jhawkins at chromium.org>'s request for review:
Bug 40397: [Chromium] Add the ability to specify a separator in
AutoFillPopupMenuChromium
https://bugs.webkit.org/show_bug.cgi?id=40397

Attachment 58316: Patch
https://bugs.webkit.org/attachment.cgi?id=58316&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebViewClient.h:295
 +	virtual void didAcceptAutoFillSuggestion(const WebNode&,
perhaps you should keep the old form of this method around and make
the default implementation of this method call that one?  that way
you won't require a two-sided patch landing to avoid regressing chrome?

WebKit/chromium/src/AutoFillPopupMenuClient.cpp:63
 +	  return suggestion;
nit: indent by 4 spaces

looks ok otherwise.