[webkit-reviews] review denied: [Bug 40389] make rietveld upload faster and avoid posting to bug on errors : [Attachment 58297] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 40389: make rietveld upload faster and avoid posting to bug on errors
https://bugs.webkit.org/show_bug.cgi?id=40389

Attachment 58297: Patch
https://bugs.webkit.org/attachment.cgi?id=58297&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good, but R- because of the race condition.

WebKitTools/Scripts/webkitpy/common/net/bugzilla.py:275
 +		return self._fetch_bug(bugs[0]).in_rietveld_queue_patches()[0]
Is there a race condition where the first query sees the bug as having a
rietveld? patch but this request doesn't?  Wouldn't that cause use to throw an
exception here?

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:338
 +	    self._reject_patch(patch.id(), message)
I'd pass the patch here for consistency with other queues.