[webkit-reviews] review denied: [Bug 36903] Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter : [Attachment 58260] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 36903: Implement BlobBuilder internal class for BlobBuilder support as
defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

Attachment 58260: Patch
https://bugs.webkit.org/attachment.cgi?id=58260&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
WebCore/html/Blob.h:74
 +	Blob(const String& type, const BlobItemList& items);
'items' can be omitted.

WebCore/html/Blob.cpp:94
 +	return Blob::create(contentType, items);
// FIXME: Pass content type when we add it to slice's arguments.
return Blob::create(String(), items);

WebCore/html/BlobBuilder.cpp:39
 +  #include "StringHash.h"
Is this include needed?

WebCore/html/BlobBuilder.cpp:41
 +  #include <wtf/HashMap.h>
Is this include needed?

WebCore/html/BlobBuilder.cpp:81
 +	if (!blob)
Probably it is simpler to say:
    if (blob)
	for (...)
	    ...
    return true;

WebCore/html/BlobBuilder.h:37
 +  #include "ExceptionCode.h"
Including ExceptionCode.h is not needed.

WebCore/html/BlobBuilder.h:51
 +	bool appendString(const WebCore::String& text, const WebCore::String&
ending, ExceptionCode& ec);
The namespace WebCore is not necessary.

WebCore/html/BlobBuilder.h:54
 +	PassRefPtr<Blob> getBlob(const WebCore::String& contentType) const;
ditto.

WebCore/platform/BlobItem.cpp:135
 +  #else
How about CR in mac?